fix: ignore request error if request is done

node-modules · Jun 28, 2022 · 94d7f5e · 94d7f5e
1 parent 518d22c
commit 94d7f5e
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/lib/urllib.js b/lib/urllib.js
@@ -1161,12 +1161,13 @@ function requestWithCallback(url, args, callback) {
     });
   }
 
-  var isRequestError = false;
+  var isRequestDone = false;
   function handleRequestError(err) {
-    if (isRequestError || !err) {
+    console.log('req error: ', err);
+    if (isRequestDone || !err) {
       return;
     }
-    isRequestError = true;
+    isRequestDone = true;
 
     if (err.name === 'Error') {
       err.name = connected ? 'ResponseError' : 'RequestError';
@@ -1178,7 +1179,9 @@ function requestWithCallback(url, args, callback) {
     debug('Request#%d pump args.stream to req', reqId);
     pump(args.stream, req, handleRequestError);
   } else {
-    req.end(body);
+    req.end(body, function () {
+      isRequestDone = true;
+    });
   }
   // when stream already consumed, req's `finish` event is emitted and pump will ignore error after pipe finished
   // but if server response timeout later, we will abort the request and emit an error in req