Skip to content

Don't run CI on draft pull requests for releases #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jankapunkt opened this issue Jan 13, 2022 · 1 comment · Fixed by #49 or #117
Closed

Don't run CI on draft pull requests for releases #116

jankapunkt opened this issue Jan 13, 2022 · 1 comment · Fixed by #49 or #117
Labels
code quality 🧽 Relating to code quality

Comments

@jankapunkt
Copy link
Member

To prevent CI from failing (and spamming our inbox) on draft pull requests (which can fail as they are reflecting work in progress) we should disable lint/tests etc. when the PR is in draft state.

According to this discussion it is solved like so:

on:
  pull_request:
    types: [review_requested, ready_for_review]
@jankapunkt jankapunkt added the code quality 🧽 Relating to code quality label Jan 13, 2022
@jankapunkt jankapunkt changed the title Don't run CI on draft pull requests Don't run CI on draft pull requests for releases Jan 13, 2022
@jankapunkt jankapunkt linked a pull request Jan 13, 2022 that will close this issue
DRAFT: Release workflows #49
Merged
@jankapunkt jankapunkt mentioned this issue Jan 13, 2022
Merged
@jankapunkt jankapunkt linked a pull request Jan 13, 2022 that will close this issue
Get release-workflow running #117
Merged
@jankapunkt
Copy link
Member Author

will be added in #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality 🧽 Relating to code quality
Projects
None yet
Milestone
No milestone
1 participant
@jankapunkt