Get release-workflow running #117
Conversation
jankapunkt
changed the title
|
sorry for the email spam on failed workflows but the paths in github actions are really a tricky one.... |
|
It's finally running through 🎉 |
jankapunkt
dismissed
jorenvandeweyer’s stale review
The base branch was changed.
|
@jorenvandeweyer I now forked the express adapter to our org and updated it so we can have integration tests with new releases and see if the express adapter breaks (which it does not right now). Was a big hassle but now it's working. Can you please take a short look at it? |
|
Okay I commented out the |
|
@Uzlopak @jorenvandeweyer @HappyZombies I need at least one reviewer in order to merge this. |
| @@ -14,6 +14,7 @@ name: "CodeQL Semantic Analysis" | |||
| on: | |||
| push: # all pushes | |||
| pull_request: # all PR | |||
| types: [review_requested, ready_for_review] # only non-draft PR | |||
There was a problem hiding this comment.
Interesting. Didn't know this..will probably add this to my projects.
| needs: [audit] | ||
| strategy: | ||
| matrix: | ||
| node: [12, 14, 16] |
There was a problem hiding this comment.
Please add node 17. We got a regression in mongoose few weeks ago, could have been detected earlier if we would have tested also for node17. Better to also add chec for node17 and later node 18 and 19, while dropping node 12 and 17.
|
|
||
| # with the following action we enforce PRs to have a high coverage | ||
| # and ensure, changes are tested well enough so that coverage won't fail | ||
| - name: check coverage |
There was a problem hiding this comment.
If we use NYC we can set minimum code coverage and then it already throws an error in the step above.
This is how I do it in a project of mine
| needs: [unittest] | ||
| strategy: | ||
| matrix: | ||
| node: [12, 14] # TODO get running for node 16 |
There was a problem hiding this comment.
Create follow up issue after merge
|
|
||
| # with the following action we enforce PRs to have a high coverage | ||
| # and ensure, changes are tested well enough so that coverage won't fail | ||
| - name: check coverage |
|
@Uzlopak let's open a new Issue since this can be implemented independently from the next release |
Summary
This PR is for testing the release workflow in action until it runs through.
No publish will be done, only dry-runs
The release-tests and code-ql workflow only runs, if the PR is non-draft
Linked issue(s)
#116 #36
Involved parts of the project
CI
Added tests?
they are the tests
OAuth2 standard
not releated
Reproduction
not releated