Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies #15

Closed
jankapunkt opened this issue Oct 10, 2021 · 10 comments
Closed

Remove dependencies #15

jankapunkt opened this issue Oct 10, 2021 · 10 comments
Labels
dependencies 🔌 Pull requests that update a dependency file

Comments

@jankapunkt
Copy link
Member

In the old thread discussion there was a mention on some deps that could be removed or replaced:

  • bluebird -> Native Node Promise
  • promisify-any -> utilis.promisify
  • statuses -> http.STATUS_CODES
@jankapunkt jankapunkt added the dependencies 🔌 Pull requests that update a dependency file label Oct 10, 2021
@HappyZombies
Copy link
Member

  • bluebird -> Native Node Promise
  • promisify-any -> utilis.promisify

Doing so would change the amount of versions of Node we support, and honestly, I am OK with that lol. Just know it's a risk.

As for statuses I think that's an easy one that can be done in a minor version. I'll make a PR for that in the future.

@jankapunkt
Copy link
Member Author

This raises the question how far we go backward in compatiblity. I think we could simply go with the official node versions support.

@HappyZombies
Copy link
Member

I agree 100%, which is great cuz it'll give us great flexibility to improve things.

@HappyZombies
Copy link
Member

@jankapunkt just to confirm, you are talking about https://www.npmjs.com/package/http-status-codes correct?

@jwerre
Copy link
Contributor

jwerre commented Oct 10, 2021

@jankapunkt, @HappyZombies, I'd be happy to jump in and help on this. I use this extensively on a large project and would like to see it actively maintained.

@jankapunkt
Copy link
Member Author

Hi @jwerre that's great. We are currently sorting out administrative steps regarding development process, contribution, code quality etc. Feel free to comment on the respective issues / pull requests.

@jwerre
Copy link
Contributor

jwerre commented Oct 10, 2021

Get, I'll let you guys go ahead and sort out all the details with regards to the project as a whole. In the mean time i'll jump in and fix these specific issues. I'm going to create three separate issues and work on them independently.

@jwerre
Copy link
Contributor

jwerre commented Oct 10, 2021

@jankapunkt
Copy link
Member Author

@HappyZombies can you add @jwerre to the org?

@HappyZombies HappyZombies added in progress 👨‍💻 Currently in progress and is being worked on. and removed in progress 👨‍💻 Currently in progress and is being worked on. labels Oct 13, 2021
@jankapunkt
Copy link
Member Author

I will close this in favour to the other three issues. Feel free to reopen if there is something left that's not covered yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 🔌 Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants