Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bluebird dependency #19

Closed
jwerre opened this issue Oct 10, 2021 · 2 comments · Fixed by #190
Closed

Remove Bluebird dependency #19

jwerre opened this issue Oct 10, 2021 · 2 comments · Fixed by #190
Labels
dependencies 🔌 Pull requests that update a dependency file on hold 🛑 We will look into it at a later time

Comments

@jwerre
Copy link
Contributor

jwerre commented Oct 10, 2021

We should be able to remove Bluebird as a dependency in favor of standard ES6 Promises.

@jwerre
Copy link
Contributor Author

jwerre commented Oct 10, 2021

Doing so would change the amount of versions of Node we support.
#15 (comment)

I'm just going to copy & paste my comment from the old repo:

It may be worth considering adding a feature where you could plug in your own Promise library (oauthjs/node-oauth2-server#621 (comment)). Since Bluebird has been such an integral part of this project many legacy applications may be depending on the extended Promise functionality that it offers. It would be much easier to plug in Bluebird in many cases that to rewrite all that code. Furthermore, if you're using a feature like Cancelations you might find yourself is a situation where upgrading is untenable. One module that did this well is Mongoosehere's what that looks like.

That said, let's have a discussion on the minimum version of Node.js we should support.

@jankapunkt
Copy link
Member

I already mentioned in the other issue that we should stick with what is officially supported by nodejs and I think in that case there is no need to have a shim. I think the last supported node is 12.x right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 🔌 Pull requests that update a dependency file on hold 🛑 We will look into it at a later time
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants