Skip to content

Replace exception library Should with Chai #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 12, 2021
Merged

Replace exception library Should with Chai #29

merged 3 commits into from
Oct 12, 2021

Conversation

jwerre
Copy link
Contributor

@jwerre jwerre commented Oct 11, 2021

Resolves issue #28

jankapunkt
jankapunkt approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@jankapunkt jankapunkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked it out and ran the tests, coverage and test resluts are exactly the same, besides being 10ms faster :-)

@jankapunkt
Copy link
Member

@HappyZombies you can take a look at it if you want, from my end it is good to go

@jankapunkt jankapunkt linked an issue Oct 11, 2021 that may be closed by this pull request
Replace should with chai #28
Closed
@HappyZombies
Copy link
Member

HappyZombies commented Oct 11, 2021 •
edited
Loading

I will look into it further more today and into tomorrow maybe.

HappyZombies
HappyZombies reviewed Oct 12, 2021
View reviewed changes
Copy link
Member

@HappyZombies HappyZombies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question and small indentation. Once resolved I will merge. But looks good on my end too

test/unit/models/token-model_test.js Outdated
@@ -18,7 +18,8 @@ describe('Model', function() {
};

var model = new TokenModel(data);
model.accessTokenLifetime.should.be.Number;
should.exist(model.accessTokenLifetime);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation here is off by a bit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops... I need to set up some workspace setting for this project. It's the only one in which I use spaces ;)

@HappyZombies HappyZombies mentioned this pull request Oct 12, 2021
Merged
@HappyZombies HappyZombies added the dependencies 🔌 Pull requests that update a dependency file label Oct 12, 2021
@HappyZombies
Copy link
Member

Looks good! Merging.

@HappyZombies HappyZombies merged commit a6c257f into development Oct 12, 2021
@jankapunkt jankapunkt mentioned this pull request Oct 13, 2021
Merged
@jwerre jwerre deleted the chai branch November 21, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HappyZombies HappyZombies HappyZombies left review comments

@jankapunkt jankapunkt jankapunkt approved these changes

Assignees
No one assigned
Labels
dependencies 🔌 Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace should with chai
3 participants
@jwerre @jankapunkt @HappyZombies