integrate basic-auth #60
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also added lint:fix as new script... was easier than adding the missing semicolons by hand. lol |
|
D'oh. Please run the tests again. |
|
Please change the destination to |
|
Ok, will do ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #57 it could be a security issue, that the basic-auth package could be potentially hijacked.
This PR integrates basic-auth npm package into node-oauth2-server.
I checked with safeRegex if the regexes are safe from catastrophic backtracking.
I removed safe-Buffer as dependency, as we are supporting modern node versions anyway. Also reducing potential attack vector by a hijacked safe-Buffer-package.
Unit tests were integrated also.