Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv4 fragments reassembly and correction for decode invalid values on fragments (issue #173) #174

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

felipeaf
Copy link
Collaborator

@felipeaf felipeaf commented Aug 5, 2015

I was unable to check content of fragmented packets, and trying decode packets that are fragments make wrong headers in transport layer. Addictionally, before this commit was impossible to manual merge fragments to reassembly the original payload of ip fragments, due to the fact the bytes were lost because was handled like a header, when just the first fragment has a transport layer header.

Felipe Alexandre Ferreira added 2 commits August 5, 2015 09:51
…r to reassembly the original packet, since we can't correctly decode payloads of fragments without reassembly
@felipeaf felipeaf changed the title IPv4 fragments reassembly and correction for decode invalid values on fragments (issue 173) IPv4 fragments reassembly and correction for decode invalid values on fragments (issue #173) Aug 5, 2015
@jmaxxz
Copy link
Collaborator

jmaxxz commented Aug 18, 2015

I think handling this case is a good idea. However, I would like to see a couple changes prior to accepting this into master.

  • Move sample programs to external repository you maintain. (Which we will link to from the readme)
  • Add a test for this case, if it is worth adding this functionality today it is worth making sure it works tomorrow.
  • Introduce a IPv4Fragment decoder which raises an event on an ipv4 fragment. (This way the payload of the ipv4 packet is an ipv4 fragment. The example app does not have to inspect all packets to find fragments)

Finally, thank you work the work you have put into this so far.

@mranney
Copy link
Collaborator

mranney commented Jan 11, 2016

Hi there. Thanks for the contribution. I've added you as a collaborator on this project. Feel free to continue development and merge as you see fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants