Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pass in wemo address as msg.ipaddr. #115

Closed
wants to merge 1 commit into from
Closed

Add ability to pass in wemo address as msg.ipaddr. #115

wants to merge 1 commit into from

Conversation

kerber
Copy link

@kerber kerber commented May 11, 2015

Inspired by http request I've modified the Wemo out node to handle passing in a device address as msg.ipaddr.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.8% when pulling e96c65c on kerber:patch-1 into 36ac381 on node-red:master.

@kerber
Copy link
Author

kerber commented May 11, 2015

I apologize for the pull request without CLA. I hadn't read the contributing guide. I'm happy keeping my own branch.

@dceejay
Copy link
Member

dceejay commented Sep 8, 2015

Hi @kerber,
would you like to complete the CLA to get this PR in ? Or shall we close ?
If the former - then would it make sense to update the html file to add the option to the help/info panel ?

@kerber
Copy link
Author

kerber commented Sep 9, 2015

Hey @dceejay,
I'm just going to close this pull request. I ended up not using the modified code and I'm a bit swamped with other projects at the moment. Sorry for leaving it open for so long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants