Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default initiate a login-request #41

Closed
rubenstolk opened this issue Jun 18, 2014 · 4 comments
Closed

By default initiate a login-request #41

rubenstolk opened this issue Jun 18, 2014 · 4 comments

Comments

@rubenstolk
Copy link
Contributor

Currently for getting the lib to work we have to provide the samlFallback property to be login-request, however, I wonder why we should call it fallback.

I believe the default should be login-request (like the older version of the lib was doing).

@ploer
Copy link
Contributor

ploer commented Jun 18, 2014

Yeah, I've been thinking the same thing, but I haven't figured out quite what the history of this was.

@ploer
Copy link
Contributor

ploer commented Jun 18, 2014

I'll take a look at this.

@ploer
Copy link
Contributor

ploer commented Jun 20, 2014

I hadn't realized it, but this was introduced from the passport-saml-too branch, and wasn't in older versions of the library.

Changed it to have the appropriate behavior by default. ad95a21

@ploer ploer closed this as completed Jun 20, 2014
@rubenstolk
Copy link
Contributor Author

Thanks Peter!—
Sent from Mailbox

On Fri, Jun 20, 2014 at 11:13 PM, Peter Loer notifications@github.com
wrote:

I hadn't realized it, but this was introduced from the passport-saml-too branch, and wasn't in older versions of the library.

Changed it to have the appropriate behavior by default. ad95a21

Reply to this email directly or view it on GitHub:
#41 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants