Ability to add additional query parameters in authorize, logout or all requests. This PR fixes #57. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- additionalParams - additionalAuthorizeParams - additionalLogoutParams
- additionalParams - additionalAuthorizeParams - additionalLogoutParams
|
Thanks, Tomasz, looks great at first glance! The one thing I would ask is whether you could add some test cases to cover the new functionality. Unfortunately I am mostly unconnected for the next several days so it will probably be next week before I can review in a little more detail & merge. |
|
@ploer Sure, done. Actually - sorry for not doing that straight away, bad practice. |
ploer
added a commit
that referenced
this pull request
Nov 14, 2014
Ability to add additional query parameters in authorize, logout or all requests. This PR fixes #57.
|
Merged & published. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.