Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust type enforcement to remove warnings #889

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

cjbarth
Copy link
Collaborator

@cjbarth cjbarth commented Mar 6, 2024

There was only a single warning when linting, about the any type. Removing the any type in this case would be vary arduous, so we leave it as-is and remove the linting warning.

@cjbarth cjbarth added the chore Refactoring, etc. to keep code-rot in check. label Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.42%. Comparing base (cf541a5) to head (ccd5284).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #889   +/-   ##
=======================================
  Coverage   64.42%   64.42%           
=======================================
  Files           4        4           
  Lines         149      149           
  Branches       37       37           
=======================================
  Hits           96       96           
  Misses         30       30           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cjbarth cjbarth merged commit 2389a5e into node-saml:master Mar 6, 2024
8 checks passed
@cjbarth cjbarth deleted the clean-types branch March 6, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactoring, etc. to keep code-rot in check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant