Pass stream ID arrays when calling peerConnection.addTrack and addTransceiver #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch C++ versions -addTrack modified from taking a MediaStream pointer to a taking in a vector of strings / media stream ids -addTransceiver modified from taking a RtpTransceiverInit property that contains a vector of media streams, to one that takes a vector of strings / media stream ids -attempted to modify the required test and javascript files -including the marking some potential additional work with TODOs in rtcrtpsender.js
…ia stream id via new RTCMediaStreamInit struct -added a unit test for this new constructor to test/mediastream.js -modified PeerConnection AddTrack to accept a vector of MediaStream's -reverted previous changes to RtpTransceiverInit so we go back to accepting a vector of MediaStreams -enabled rtcrtpsender.js test in all.js test suite -adjusted test/rtcrtpsender.js for new addTrack signature that now accepts a vector of MediaStreams -corrected test/rtcrtpsender.js expected test results for removeTrack
markandrus
reviewed
Feb 2, 2020
|
|
||
| #define DICT(X) RTC_MEDIA_STREAM_INIT ## X | ||
| #include "src/dictionaries/macros/impls.h" | ||
| #undef DICT |
| #define DICT(X) RTC_MEDIA_STREAM_INIT ## X | ||
| #include "src/dictionaries/macros/def.h" | ||
| #include "src/dictionaries/macros/decls.h" | ||
| #undef DICT |
test/destructor/index.js
Outdated
| @@ -109,9 +109,9 @@ test('Destructors fire in MediaStreamTrack use-case', async t => { | |||
|
|
|||
| const [pc1, pc2] = await negotiateRTCPeerConnections({ | |||
| withPc1(pc1) { | |||
| stream1.getTracks().forEach(track => pc1.addTrack(track, stream1)); | |||
| stream1.getTracks().forEach(track => pc1.addTrack(track, [stream1])); | |||
There was a problem hiding this comment.
Per comment above, using rest parameter syntax, there should be no change necessary here.
-reverted some changes to test/destructor/index.js and rtcrtpsender.js since array is no longer needed with rest syntax -added test case to rtcrtpsender.js for multiple streams in addTrack and duplicate stream id's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #546
This pull request contains our proposal to supply media stream IDs from the javascript peer connection addTrack() and addTransceiver() methods. IDs are passed in as an array, which is similar to the underlying WebRTC API.