Skip to content

Conversation

@RubenVerborgh
Copy link
Contributor

The server tests now run with Node 8, and this is tested on Travis.

The main problem was that setting NODE_TLS_REJECT_UNAUTHORIZED at runtime through process.env didn't work anymore. I have replaced this by the rejectUnauthorized configuration option where possible, which fixed the ACL TLS test (and can be useful for local testing). Unfortunately, the supertest library does not allow to set that option, so I set is a an environment variable before calling the Mocha tests.

The remaining problem is that Nock is currently incompatible with Node 8, so for now, I have just skipped those 4 tests that use Nock.

@dmitrizagidulin
Copy link
Contributor

@RubenVerborgh Nice job tracking down these issues! I wonder if we should wait until Nock works with node 8 before merging this... (I don't suppose Travis allows you to execute different scripts for different node versions?)

@RubenVerborgh
Copy link
Contributor Author

I personally wouldn't wait for Nock; I find it very strange that they haven't tackled their issues already. It seems more important to me that we do test for Node 8 (whereas Nock currently doesn't) to avoid breaking things.

It would be possible to have a switch statement per Node version. However, given that we know the proxy tests work on v6, and given that these tests only depend on the proxy and nothing else, I don't see a problem. If somebody wants to work on the proxy in the future, they will likely look at the proxy tests anyway.

@RubenVerborgh RubenVerborgh self-assigned this Aug 8, 2017
@RubenVerborgh
Copy link
Contributor Author

Nock has been updated, so I can update this PR.

@RubenVerborgh
Copy link
Contributor Author

@dmitrizagidulin Rebased to the latest dz_oidc.

@dmitrizagidulin
Copy link
Contributor

@RubenVerborgh ok, it's ready to go on your end?

@RubenVerborgh
Copy link
Contributor Author

Totally!

@dmitrizagidulin dmitrizagidulin merged commit d9b77a8 into dz_oidc Aug 9, 2017
@dmitrizagidulin dmitrizagidulin deleted the rv/node8 branch August 9, 2017 17:46
@RubenVerborgh RubenVerborgh added this to the 4.0.0 milestone Aug 10, 2017
RubenVerborgh added a commit that referenced this pull request Aug 10, 2017
RubenVerborgh added a commit that referenced this pull request Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants