Allow WebID+TLS behind a reverse proxy #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WebID-TLS implementation assumed an end-to-end TLS connection from the client to the server, so reverse proxies were not possible. With this commit, the reverse proxy can terminate the TLS connection and pass the client certificate through the X-SSL-Cert HTTP header.
This is a native module, which might not compile on all platforms. Furthermore, it is only needed for header-based WebID auth.
RubenVerborgh
force-pushed
the
feature/tls-cert-header
branch
from
65657ed to
d328423
Compare
Contributor
|
@RubenVerborgh looks good! Thanks. |
dmitrizagidulin
approved these changes
Jul 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests extends the Solid server with an
acceptCertificateHeaderoption. If enabled (default: no), the Solid server accepts a client certificate in PEM format through theX-SSL-CertHTTP header.This can be used in combination with the following NGINX options:
That way, NGINX can terminate the SSL connection (and thus run multiple services on port 443), whereas Solid can still check whether the certificate matches the WebID.
Security considerations
In this configuration, the Solid server does not verify whether the client has the matching private key to the certificate (NGINX does). As such,
acceptCertificateHeadershould never be enabled on front-facing servers.