Remove debug overhead on ACL #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-f
reviewed
Aug 31, 2017
| debug('Authentication required') | ||
| throw new HTTPError(401, `Access to ${this.resource} requires authorization`) | ||
| } else { | ||
| debug(`${mode} access denied for ${user}`) |
There was a problem hiding this comment.
This seems like a useful message, no?
There was a problem hiding this comment.
It is, just not 8 times 😉 That's why I moved it here: https://github.com/solid/node-solid-server/pull/566/files#diff-b11433f1fb19c85e170915d27502d490R43
| .then(() => next(), next) | ||
| const userId = req.session.userId | ||
| req.acl.can(userId, mode) | ||
| .then(() => next(), err => { |
There was a problem hiding this comment.
Nitpick: can replace () => next() with next
There was a problem hiding this comment.
We can't: the promise resolves to a non-falsy value (true), and the first parameter of next being truthy is interpreted as an error.
RubenVerborgh
added a commit
that referenced
this pull request
Sep 3, 2017
* dz_oidc: (178 commits) Rename the idp option into multiuser (#570) Add a /public folder in new accounts (#569) Update Data Browser html file Remove debug overhead on ACL (#566) Fix requirement for additional verification logging in with WebID-TLS Add bootstrap.min.css.map to common/css/ Add current hash to redirect. (#562) Disable rejectUnauthorized on the WebID-TLS endpoint. (#561) Serve static common/ dir relative to __dirname Tweak account index page phrasing Remove solid:inbox from template Add support for external WebIDs registering with username & password Move RS options to oidc-auth-manager initialization Do not check for user header in oidc test Log whole error in error handler Expand error message for unverified web id Bump oidc-auth-manager dep to 0.12.0 Verify presence of test DNS entries. (#549) Expose WAC-Allow to browser clients. Remove async dependency. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #558, the debug output for the same action is now: