Use data browser for containers as well #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Requires an entry in CHANGELOG (#534). |
Contributor
|
👍 because this un-breaks file browsing on For the long term, I think it's worth discussing file browsing UX, and how to make the default experience accessible. |
dan-f
approved these changes
Sep 5, 2017
| .set('Accept', 'text/html') | ||
| .expect('content-type', /text\/html/) | ||
| .expect(303, done) | ||
| .expect(200, done) |
Contributor
There was a problem hiding this comment.
Not your problem, but this test does not in any way "show data browser if container was requested as text/html" 🤦♂️
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Warp as well as the separate
--file-browseroption. Closes #537.