-
Notifications
You must be signed in to change notification settings - Fork 305
Allow cookies from all subdomains #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lib/models/solid-host.js
Outdated
| } | ||
| } | ||
|
|
||
| function getHostName (origin) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't using origin confuse that there may be other URIs that the hostname is extracted from than the Origin? Or am I confused for other reasons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I will change the parameter name.
kjetilk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I think I understand what it does, and it appears sensible, but I don't understand why it does it, so I think I'll leave the approval to others.
51e43c8 to
0170a22
Compare
kidehen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Authorization now works, as per "it just works!" interop page.
I was able to add data to @RubenVerborgh's pod in line with RWWCrew ACLs.
See confirmation tweet .
|
I works, but I found some corner cases we are going to hit. Explanation tomorrow, I will now PR @kidehen's workaround to it (which doesn't have the corner cases). |
A side-effect of #793 is that the security mechanism of #526 is not just applied to the cookie-based login method, but to all login methods (WebID-TLS, WebID-OIDC). #526 rejected cookies as authentication mechanism from third-party hosts, requiring other hosts to always send a Bearer header.
However, its definition of "other hosts" did not include subdomains. For example:
This pull request changes things such that
This addresses breakage in 4.1.4 and 4.1.5 caused by #793 as noted by @kidehen in #793 (comment)