Skip to content

Conversation

@RubenVerborgh
Copy link
Contributor

@RubenVerborgh RubenVerborgh commented Oct 2, 2018

A side-effect of #793 is that the security mechanism of #526 is not just applied to the cookie-based login method, but to all login methods (WebID-TLS, WebID-OIDC). #526 rejected cookies as authentication mechanism from third-party hosts, requiring other hosts to always send a Bearer header.

However, its definition of "other hosts" did not include subdomains. For example:

This pull request changes things such that

This addresses breakage in 4.1.4 and 4.1.5 caused by #793 as noted by @kidehen in #793 (comment)

}
}

function getHostName (origin) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't using origin confuse that there may be other URIs that the hostname is extracted from than the Origin? Or am I confused for other reasons?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I will change the parameter name.

Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think I understand what it does, and it appears sensible, but I don't understand why it does it, so I think I'll leave the approval to others.

@RubenVerborgh RubenVerborgh force-pushed the fix/allow-subdomain-cookies branch from 51e43c8 to 0170a22 Compare October 2, 2018 20:07
Copy link

@kidehen kidehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authorization now works, as per "it just works!" interop page.
I was able to add data to @RubenVerborgh's pod in line with RWWCrew ACLs.

See confirmation tweet .

@RubenVerborgh
Copy link
Contributor Author

I works, but I found some corner cases we are going to hit. Explanation tomorrow, I will now PR @kidehen's workaround to it (which doesn't have the corner cases).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants