Skip to content

Update base64url deps, refresh dev dependencies #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2018
Merged

Update base64url deps, refresh dev dependencies #24

merged 2 commits into from
Jun 7, 2018

Conversation

dmitrizagidulin
Copy link
Contributor

Fixes issue #23.

@dmitrizagidulin
Copy link
Contributor Author

Ah, hrm, some sort of tests failing. Fixing..

@dmitrizagidulin
Copy link
Contributor Author

Ah, ok, a sinon testing API has changed. Should be fixed now.

RubenVerborgh
RubenVerborgh approved these changes Jun 7, 2018
View reviewed changes
Copy link
Contributor

@RubenVerborgh RubenVerborgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the updates, quite some work!

All fine with me.

@dmitrizagidulin dmitrizagidulin merged commit c2f7678 into master Jun 7, 2018
@dmitrizagidulin dmitrizagidulin deleted the dz-base64url-update branch June 7, 2018 20:20
@dmitrizagidulin dmitrizagidulin mentioned this pull request Jun 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@RubenVerborgh RubenVerborgh RubenVerborgh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmitrizagidulin @RubenVerborgh