Skip to content

Ensure Headers objects are supported #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2020
Merged

Ensure Headers objects are supported #167

merged 1 commit into from
Sep 9, 2020

Conversation

@RubenVerborgh
Copy link
Contributor

@RubenVerborgh RubenVerborgh commented Sep 9, 2020

rubensworks
rubensworks approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@rubensworks rubensworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not that familiar with this code, but looks right to me. Should also be backwards-compatible.

@RubenVerborgh RubenVerborgh merged commit f284057 into master Sep 9, 2020
@RubenVerborgh RubenVerborgh deleted the fix/headers-object branch September 9, 2020 14:56
@coveralls
Copy link

coveralls commented Sep 9, 2020

Coverage Status

Coverage increased (+0.4%) to 84.324% when pulling 14133f3 on fix/headers-object into 1dd5b26 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michielbdejong michielbdejong Awaiting requested review from michielbdejong

@NSeydoux NSeydoux Awaiting requested review from NSeydoux

1 more reviewer

@rubensworks rubensworks rubensworks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RubenVerborgh @coveralls @rubensworks