Test on latest Node.js #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-f
approved these changes
Aug 16, 2017
Contributor
dan-f
left a comment
dan-f
left a comment
There was a problem hiding this comment.
Just a minor question, but LGTM!
| node_js: | ||
| - 7.10.0 | ||
| - 8 | ||
| - node |
Contributor
There was a problem hiding this comment.
Travis says node implies the latest stable node release. Is this redundant given 8 above?
Contributor
Author
There was a problem hiding this comment.
For now, yes, but not in the future. Alternative is to put "8.0" and "node", or just "8.0" (but I like auto testing on new Node.js versions).
| - yarn test | ||
| after_success: | ||
| - yarn coverage:report | ||
| cache: yarn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request runs the Travis CI tests on Node.js 8 and the latest Node.js version.