Line numbers for better error handling (WIP)

[kunal-mohta]

This presents a proposal for solving #40.
I have used the method to solve #30. You can check the method by trying to reproduce the mentioned there.
If this looks fine, I can try to implement this on all the errors thrown in the code.

[stebanos]

I'm not a fan of having the line number in Lexer. Since Parser manages the progress of the Lexer, it could catch the errors thrown in Lexer (and itself) and rethrow them with the line number added. That way, errors in Lexer don't need to be rewritten. Not for that reason anyway. Also for added consistency with the code we have already the error message should start with Line ${lineno}:

[kunal-mohta]

@stebanos This looks better?

[stebanos]

Hey Kunal, yes this is better. Will you also add in the error re-throwing?

[kunal-mohta]

Sure!

[kunal-mohta]

There are still errors thrown in the Interpreter class that need line numbers.
I guess that would need line numbers to be present in the phraseBook as well?

[stebanos]

Hehe, I think you misunderstood my last request. You added Line ${this.lineno}in front of each error. What I meant was something like this:

in the PhraseParser:

    parse() {
        try {
            const node = this.phrase();
            if (this.currentToken.type !== EOF) {
                this.error(EOF);
            }
            return node;
        } catch (e) {
            throw new Error(`Line ${this.lineno}: ${e.message}`);
        }
    }

A similar thing could be done in the Interpreter class if the phrase has access to its line number.

[kunal-mohta]

Oh! 🤦‍♂️
I am sorry.. will do that. 😅
For giving Interpreter class the access to line numbers I would need to add line numbers to the phraseBook right? Or is there a better way to do it?

[stebanos]

The Interpreter can access the phrase through this.phrase, in the screenshot you showed earlier lineno was included in the phrase, so I suppose this.phrase.linenowould just work?

[kunal-mohta]

Yes, that is what I plan to do. 👍

[kunal-mohta]

Sorry about the commit message 😓

[stebanos]

Thanks, well done!

[fdb]

I know this is now merged, but I don't understand this code. What's the line at the end? Just a typo?

[kunal-mohta]

I think that is what it is 😓
I am sorry, let me just change it.

[kunal-mohta]

@fdb I have made the correction in #43

[fdb]

👍