Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus: Remove Grafana data source and some other changes #2

Merged

Conversation

expenses
Copy link

Hello! I'm very excited about your Prometheus code! I've made a few changes that I think should improve how this crate is used.

  • Renamed from sc-prometheus to prometheus-endpoint (sc- is meant to be used for substrate client crates)
  • prometheus_endpoint re-exports lazy_static! and generic gauges which you can use like: pub static ref SYNC_TARGET: Gauge<U64> = create_gauge(...)
  • grafana-data-source is replaces with prometheus-endpoint, which results in a smaller diff between this and paritytech/master.
  • Some other small nitpicks.

@nodebreaker0-0
Copy link
Owner

good job, Thank you so much for your care.

@nodebreaker0-0 nodebreaker0-0 merged commit 9a04a6b into nodebreaker0-0:prometheus_v0.3 Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants