Prometheus: Remove Grafana data source and some other changes #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I'm very excited about your Prometheus code! I've made a few changes that I think should improve how this crate is used.
sc-prometheus
toprometheus-endpoint
(sc-
is meant to be used for substrate client crates)prometheus_endpoint
re-exportslazy_static!
and generic gauges which you can use like:pub static ref SYNC_TARGET: Gauge<U64> = create_gauge(...)
grafana-data-source
is replaces withprometheus-endpoint
, which results in a smaller diff between this andparitytech/master
.