-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #468 includes passing test #469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, but need coding style fix to pass linter.
Run make test
local to be sure. If you don't have make
, run makefile commands manually.
@puzrin I ran from Makefile and saw the linter errors but wanted feedback before applying linting fixes. |
#sign-off |
@puzrin Please let me know if there are other changes you need. |
No description provided.