Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #468 includes passing test #469

Merged
merged 7 commits into from
Feb 26, 2019
Merged

Fix for issue #468 includes passing test #469

merged 7 commits into from
Feb 26, 2019

Conversation

diberry
Copy link
Contributor

@diberry diberry commented Feb 24, 2019

No description provided.

Copy link
Member

@puzrin puzrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, but need coding style fix to pass linter.

Run make test local to be sure. If you don't have make, run makefile commands manually.

test/issues/0468.js Outdated Show resolved Hide resolved
test/issues/0468.js Outdated Show resolved Hide resolved
@diberry
Copy link
Contributor Author

diberry commented Feb 24, 2019

@puzrin I ran from Makefile and saw the linter errors but wanted feedback before applying linting fixes.

.vscode/launch.json Outdated Show resolved Hide resolved
test/issues/0468.js Outdated Show resolved Hide resolved
@diberry
Copy link
Contributor Author

diberry commented Feb 24, 2019

#sign-off

test/issues/0468.js Outdated Show resolved Hide resolved
@diberry
Copy link
Contributor Author

diberry commented Feb 25, 2019

@puzrin Please let me know if there are other changes you need.

@puzrin puzrin merged commit 99c0bf9 into nodeca:master Feb 26, 2019
@jacob-hd
Copy link
Contributor

jacob-hd commented Mar 6, 2019

@diberry @puzrin Sorry I missed this edge case... thanks for implementing the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants