Patch: pako and Z_SYNC_FLUSH #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Vitaly,
attached is a pull request for adding Z_SYNC_FLUSH support to the high-level wrapper.
This allows flushing the de/compression to send out / receive interim chunks without loosing the context.
I have checked that all your existing tests still succeed (so nothing broke after my changes) and have tested the now working Z_SYNC_FLUSH in my own application. Hopefully I will find the time to add a test for Z_SYNC_FLUSH to your own test-cases in tests/*.js later as well. I will create another pull request for that. For now I can report that "make check" and "make coverage" still pass all tests.
The documentation is changed as well, clarifying the new possibilities.
Please have a look if you can merge these changes for the next pako release.
Thanks and best regards
Tino