chore: update to react 18 and typescript 4.5 #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosFdez
changed the title
|
I was about to PR my own update and then found this one. Pretty annoying having dependency issues with it. Since this also changes the testing library to testing-library/react it would also close #22. |
|
I don't know how un-maintained this project is but would love to see this PR get in to fix build warnings/errors. |
Hoishin
pushed a commit
that referenced
this pull request
Mar 15, 2023
* chore(deps): update react dependency to version 18 * fix: generic type and pre-commit linting * fix(ci): update node versions to more relevant versions * fix(tests): updated tests and fixed more linter issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typescript is still a bit behind, but so are some of our nodecg projects. I plan to eventually add suspense support and passing replicants in directly for a project, but having npm not scream at us for a very out of date react is nice as a starter.