Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use as a dependency of another node project? #110

Closed
heff opened this issue Oct 30, 2013 · 8 comments
Closed

Use as a dependency of another node project? #110

heff opened this issue Oct 30, 2013 · 8 comments

Comments

@heff
Copy link

heff commented Oct 30, 2013

With the install script, I'm assuming this can't be easily used as an NPM dependency of another project, is that right? I'm hoping to find a node-git lib that can.

@tbranyen
Copy link
Member

Me too, lets work on getting it there ;-)

@heff
Copy link
Author

heff commented Oct 30, 2013

What needs to happen to make the install script not needed?

@tbranyen
Copy link
Member

The install script isn't the issue. We just need to improve it to work as
well as something like socket.io.
On Oct 30, 2013 11:40 AM, "Steve Heffernan" notifications@github.com
wrote:

What needs to happen to make the install script not needed?


Reply to this email directly or view it on GitHubhttps://github.com//issues/110#issuecomment-27401286
.

@heff
Copy link
Author

heff commented Oct 30, 2013

I don't know enough about either project to know what that means, but happy to try to help if it can be narrowed down to specific tasks.

On Oct 30, 2013, at 8:47 AM, Tim Branyen notifications@github.com wrote:

The install script isn't the issue. We just need to improve it to work as
well as something like socket.io.
On Oct 30, 2013 11:40 AM, "Steve Heffernan" notifications@github.com
wrote:

What needs to happen to make the install script not needed?


Reply to this email directly or view it on GitHubhttps://github.com//issues/110#issuecomment-27401286
.


Reply to this email directly or view it on GitHub.

@nkallen
Copy link
Contributor

nkallen commented Nov 1, 2013

I don't really follow this thread. I've used this project as a dependency. Does it not work as a transitive dependency? Have you verified this and can paste error messages?

@tbranyen
Copy link
Member

tbranyen commented Nov 1, 2013

@nkallen This project does not easily work on Windows or any machine that doesn't have CMake natively installed. That makes it different from every other easily consumable NPM module. There are a handful of well done native modules that either offer a pure JS alternative and only use native code if it can be compiled and executed as a speed boost (see Socket.io or node-mongo-native) or fetch binaries. I've started working on this, but I'm not 100% sure how to easily generate a binary for every compatible system. An example of a project that does this is the node phantomjs module.

@heff
Copy link
Author

heff commented Nov 1, 2013

For my own purposes, the answer to my original question is that it can be used as a dependency. I misread the build instructions in the readme as the way to install the lib. Sorry.

@heff heff closed this as completed Nov 1, 2013
@tbranyen
Copy link
Member

tbranyen commented Nov 1, 2013

Okay I still would like to encourage forward movement on the project by making the library suitable for general use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants