Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree_entry path function not working when calling getEntry with a path including subdir #570

Closed
jfremy opened this issue May 15, 2015 · 0 comments

Comments

@jfremy
Copy link
Contributor

jfremy commented May 15, 2015

When building the path of a tree entry, nodegit recursively take the path of each entry's tree parent.
However this does not work if the entry was in a subdir of the parent tree because then we'll be missing the subdir.

As an example:
getEntry("test/rawcommit.js") => entry path will be returned as "rawcommit.js"

I'm submitting a push request + test with a potential fix for discussion

tbranyen added a commit that referenced this issue May 15, 2015
Fix path function in tree_entry (fix for issue #570)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants