Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JavaScript Tag.listMatch function for git_tag_list_match #1470

Merged
merged 1 commit into from
Apr 6, 2018

Conversation

rcjsuen
Copy link
Member

@rcjsuen rcjsuen commented Mar 23, 2018

I updated the descriptor file to add support for git_tag_list_match. This function was asked about on Slack.

Made changes to descriptor.json to add support for
git_tag_list_match.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
@sergebesson
Copy link

this is me who asked about it on slack. I wanted to use this method to list all tags beginning by "v_".
Example, following the documentation nodegit.tag.listMatch:

const NodeGit = require("nodegit");

NodeGit.Repository.open("MyProject")
  .then((repo) => {
    const listTags = [];
    const result = NodeGit.Tag.listMatch(listTags, "v_*", repo);
    if (result === 0) {
       console.log("list version tags", listTags);
    }
  })
  .catch((error) => {
    console.log("error", error.stack);
  });

I saw your changes, is that method going to be async ?

@rcjsuen
Copy link
Member Author

rcjsuen commented Mar 26, 2018

@sergebesson Yes, it will be asynchronous.

@implausible implausible merged commit 859a9e6 into nodegit:master Apr 6, 2018
@rcjsuen rcjsuen deleted the listmatch branch April 6, 2018 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants