Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status and StatusList #374

Merged
merged 21 commits into from
Feb 4, 2015
Merged

Status and StatusList #374

merged 21 commits into from
Feb 4, 2015

Conversation

orderedlist
Copy link
Collaborator

Statusssessssssssss

orderedlist and others added 9 commits January 30, 2015 11:55
@orderedlist
WIP for status lists
462675f
@orderedlist
Adding status_options to the descriptor
f84ff24
@orderedlist
Move git_status_options to suppliment.json
6a51573
@maxkorp
move status list methods off of status
c89d436
@maxkorp
add other methods that refer to git_status_options
b345eb5
@orderedlist
un-async git_status_list_new
e5dbacb
@orderedlist
Fix merge_tree_flat to status_opt
da612cb
@orderedlist
Enable git_status_foreach
262d2fa
Started getting callback functions working in classes
c09c4f5 
Unlike structs, classes don't store the callbacks on the object.
Instead they are passed into the function and have to be hanled
differently. Currently this is breaking the combyne templating
and after that is fixed this should build. But this is what we
need to get going for status and diff to start working.
@johnhaley81
Copy link
Collaborator

@orderedlist So the latest commit that I pushed is what I think we're going to need to implement to get that callback stuff working. Currently something is breaking the combyne templating when it's loading the partial templates. I saw this in asyncFunction, syncFunction and callbackHelper. @tbranyen might know what's going on but I didn't see anything wrong with the additions.

@orderedlist orderedlist changed the title WIP for Status and StatusList [WIP] Status and StatusList Feb 2, 2015
@johnhaley81
Copy link
Collaborator

@orderedlist ok this is building now. You should be able to start working with the callbacks now hopefully.

@johnhaley81 johnhaley81 mentioned this pull request Feb 3, 2015
Merged
@orderedlist orderedlist changed the title [WIP] Status and StatusList Status and StatusList Feb 3, 2015
@maxkorp maxkorp mentioned this pull request Feb 4, 2015
Closed
orderedlist added a commit that referenced this pull request Feb 4, 2015
@orderedlist
Merge pull request #374 from nodegit/ol-status
e3d82d0 
Status and StatusList
@orderedlist orderedlist merged commit e3d82d0 into master Feb 4, 2015
@orderedlist orderedlist deleted the ol-status branch February 4, 2015 02:11
@tbranyen tbranyen added this to the 0.3.0 milestone Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@orderedlist @johnhaley81 @tbranyen @maxkorp