Update to libgit2 v0.22.1 #390
Conversation
|
Currently the missing callbacks are breaking the build and that's what I'm working on putting in. |
When including `git2/sys/stream.h` we'll get a compile time error. Our fork of this fixes it for right now and we'll switch back over to libgit2 proper after the PR is merged back into the maint/0.22 branch
johnhaley81
force-pushed
the
update-libgit2-0.22.0
branch
from
bb70c77 to
969452a
Compare
|
Currently playing whack-a-bug with building. Fix a bug/build/fix next bug/build/etc... |
OMG IT BUILDS
|
That test passing on Travis is a false positive. |
This reverts commit 902b837.
I added a skip on the HTTP test because although github does a redirect to HTTPS which might fail cert check on osx, libgit2 originally detects the HTTP and throws an error that a cert check is defined.
I added a skip for the "fetch all" test since it's timing out right now and I'm not sure why. I'm skipping it since it breaks all of the other tests after it.
|
So there's still some things that are funky right now. With the "fetch all" test it's killing nodegit somehow. I think something's going on in C++ that's not getting cleaned up properly. I haven't been able to track it down. Now with the http test we have libgit2 anrgy that we're setting a cert check on http since http doesn't use any certification. However, this particular http call redirects to https which then does use a cert which sometimes dies on osx. I think I'll open up an issue on libgit2 about that since that seems like an oversight. |
|
libgit2/libgit2#2904 for HTTP redirect to HTTPS cert check. |
|
All of the examples are working. I think after we get Windows green lit we can merge this in! |
johnhaley81
changed the title
This is the current status on updating nodegit to use the latest
libgit2. There are some major breaking API changes that need to be
accounted for and will force nodegit to also do a major update as
well.