Throttle callbacks (again) + crash fix #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fix #919 |
johnhaley81
force-pushed
the
throttle-crash-fix
branch
from
1e585ea to
942c514
Compare
srajko
changed the title
srajko
force-pushed
the
throttle-crash-fix
branch
3 times, most recently
from
a5fc13c to
e988385
Compare
srajko
changed the title
This HandeScope was introduced with throttling changes, and may have contributed to the crash.
srajko
force-pushed
the
throttle-crash-fix
branch
from
e988385 to
666bb18
Compare
This check was removed with throttling changes, and may have contributed to the crash.
srajko
force-pushed
the
throttle-crash-fix
branch
from
666bb18 to
b0089b0
Compare
|
We've been running this in GK now with no reports of breakage. 👍 this is gtg. Thanks @srajko! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the removal of throttling, and adds two changes that seem to resolve the crash. The likely fix is 1e585ea, which restores some logic I omitted in the refactoring, thinking it should not make a difference... but it looks like it did.
I am a little worried about the state of the raw object making a difference after its wrapper has been destroyed, but maybe I'm just missing the big picture of what's happening here. In any case, the logic matches what we were doing before, and no crash is better than crash.