Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode uri to support utf8 chars #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Encode uri to support utf8 chars #46

wants to merge 2 commits into from

Conversation

RobinQu
Copy link

@RobinQu RobinQu commented Aug 29, 2012

A filename, which is part of request URI in many APIs, is not necessary to be consisted of only English chars.

Considering support for such non-asci chars, we should encodeURI() before sending the request.

In fact, current implementation of storageUrl and cdnUrl really annoys me when uploading files with Chinese file names as the server responds no error but files are nowhere to be seen on the Cloudfile.

And the problem goes away with this fix.

@indexzero
Copy link
Member

Sorry for the delay here! We've been waiting on all the issues / pull-requests for node-cloudfiles and node-cloudservers until we released pkgcloud: a new cross-provider unified IaaS library for node.js:

https://github.com/nodejitsu/pkgcloud
http://blog.nodejitsu.com/introducing-pkgcloud

We added a deprecation notice for this library, but would you consider reimplementing your pull-request for the Rackspace provider in pkgcloud? It would make you a HERO in my book 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants