Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport WHATWG URL to 6.x? #208

Closed
jasnell opened this issue Apr 28, 2017 · 15 comments
Closed

Backport WHATWG URL to 6.x? #208

jasnell opened this issue Apr 28, 2017 · 15 comments

Comments

@jasnell
Copy link
Member

jasnell commented Apr 28, 2017

Now that the WHATWG URL implementation is close to graduating from Experimental status, I would like to open a discussion about whether it makes sense to backport the implementation to 6.x..

/cc @targos @TimothyGu @watilde @joyeecheung @nodejs/lts

@TimothyGu
Copy link
Member

New features don't seem to be covered by the range of accepted changes in the LTS Plan

@jasnell
Copy link
Member Author

jasnell commented Apr 28, 2017

They can on a case by case basis during the Active LTS phase.

@TimothyGu
Copy link
Member

Okay, rules notwithstanding personally I think it is a great addition. As a maintainer of node-fetch, the availability of a high-performance standard-compliant URL parser in all supported Node.js versions would be a boon for tricky bugs like node-fetch/node-fetch#245.

@MylesBorins
Copy link
Contributor

MylesBorins commented Apr 28, 2017 via email

@joyeecheung
Copy link
Member

Can't see any harm in the idea...so +1

@gibfahn
Copy link
Member

gibfahn commented Apr 28, 2017

+1, seems reasonable once it's graduated.

@targos
Copy link
Member

targos commented Apr 28, 2017

SGTM

@watilde
Copy link
Member

watilde commented Apr 28, 2017

Sounds good to me as well.

@sam-github
Copy link
Contributor

+1 once not experimental

@kumar303
Copy link

It looks like it's graduated from experimental status now, right? nodejs/node#12710

@jasnell
Copy link
Member Author

jasnell commented Sep 14, 2017

Yes. It's no longer experimental

@gibfahn
Copy link
Member

gibfahn commented Sep 16, 2017

This has plenty of +1s, so I guess it's just waiting for someone to raise a backport PR.

@TimothyGu
Copy link
Member

Backport PR: nodejs/node#17365

@mhdawson
Copy link
Member

+1 from me as well.

@MylesBorins
Copy link
Contributor

Coming out in 6.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants