Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release plan - v10.x Maintenance #504

Closed
BethGriggs opened this issue Nov 18, 2019 · 14 comments
Closed

Release plan - v10.x Maintenance #504

BethGriggs opened this issue Nov 18, 2019 · 14 comments

Comments

@BethGriggs
Copy link
Member

BethGriggs commented Nov 18, 2019

[Draft schedule]

Week Release candidate Approximative date Release Releaser
2020 - 02 2019-12-24 2020-01-07 v10.18.1 @BethGriggs
2020 - 06 2020-02-06 v10.19.0 @BethGriggs
2020 - 12 2020-02-27 2020-04-07 v10.20.0 @BethGriggs
2020 - 23 2020-06-02 v10.21.0 (Security) @BethGriggs
2020 - 30 2020-07-02 2020-07-21 v10.22.0 @BethGriggs (prepared by @richardlau)
2020 - 38 2020-09-15 v10.22.1 (Security) @BethGriggs
2020 - 44 2020-10-13 2020-10-27 v10.23.0 @richardlau
2021 - 1 2021-01-04 v10.23.1 (Security) @richardlau
2021 - 4 2021-01-26 v10.23.2 @richardlau
2021 - 6 2021-02-09 v10.23.3 @richardlau
2021 - 8 2021-02-23 v10.24.0 (Security) @richardlau

//cc @nodejs/release

@richardlau richardlau pinned this issue Nov 18, 2019
@BethGriggs
Copy link
Member Author

There's a delay to this weeks RC due to test failures on the v10.x branch that I am still digging into - nodejs/node#30639

@MylesBorins
Copy link
Contributor

I think we may want to push of the maintenance date to May 19th thoughts?

@richardlau
Copy link
Member

In today's WG meeting I did ask about whether it was necessary to move the maintenance date (from 30th April 2020) but since the meeting ended I've remembered we would still like to move the 10.x releases to build on macOS 10.15 to address the notarization issues so giving ourselves some extra time would be good as there's a small element of risk there. So I'm now +1 to moving the maintenance date.

@mhdawson
Copy link
Member

+1 to moving from me as well due to the notarization issue.

@sam-github
Copy link
Contributor

possibly relevant: nodejs/node#32846

@richardlau
Copy link
Member

Question about a minor before going into maintenance: nodejs/node#33061 (comment). We used to have a specific exemption for n-api during maintenance but it looks like the wording got lost during #517.

@MylesBorins
Copy link
Contributor

MylesBorins commented Apr 29, 2020 via email

@BethGriggs
Copy link
Member Author

I didn't think it was unintentional, #517 aimed to generalise our policy to the following:

Maintenance - Critical bug fixes and security updates. New features may be added at the discretion of the LTS team - typically only in cases where the new feature supports migration to later release lines.

Refs: #517 (comment)

But with that being said, I wouldn't be against calling out the N-API exemption specifically again.

@mhdawson
Copy link
Member

@BethGriggs I think it's useful to have the agreement related to N-API captured so it would be good to put that back in.

@legendecas
Copy link
Member

typically only in cases where the new feature supports migration to later release lines.

In the sense of this criteria, porting N-APIs to all LTS does support migration to later release lines, isn't it? "New features may be added at the discretion of the LTS team" is ok-ish.

@Flarna
Copy link
Member

Flarna commented Jun 11, 2020

Not sure if this is the right issue to comment as 10.x has move from active LTS to maintaince as far as I know.

Anyhow, are there any indications when the next 10.x release happens?
Reason why I ask is that nodejs/node#33720 should fix stack overflow crashes we see in some environments during loading a native addon.

@richardlau
Copy link
Member

Not sure if this is the right issue to comment as 10.x has move from active LTS to maintaince as far as I know.

Anyhow, are there any indications when the next 10.x release happens?
Reason why I ask is that nodejs/node#33720 should fix stack overflow crashes we see in some environments during loading a native addon.

@Flarna We don't have one lined up yet but probably do have enough things to go into a new release. I've talked to @BethGriggs about myself preparing the next 10.x release as part of my onboarding as a releaser (#585). My intention is to do so after OpenJS World, and aim (no promises) for a mid-July release.

@BethGriggs BethGriggs changed the title Release plan - v10.x Active LTS Release plan - v10.x Maintenance Jul 1, 2020
@richardlau
Copy link
Member

richardlau commented Jul 1, 2020

I've penciled in the next 10.x release that I've been preparing and @BethGriggs has been mentoring me through.

There's a single PR, nodejs/node#33061, that I've asked be rebased. If that's done and is landable then the next release will be a minor, otherwise it will be patch. Aiming to have the proposal up tomorrow (or at least when it's clearer whether the release will be minor or patch as the branch name usually reflects the version).

The approximate date is based on us usually releasing on Tuesdays and to give the customary two weeks for the release candidate.

@richardlau
Copy link
Member

I'm volunteering to do a release around 27 Oct 2020. This is mainly to include some N-API updates and the open v10.x backport PRs.

cc @nodejs/releasers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants