Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing python 2.7 #538

Closed
Pomax opened this issue Feb 21, 2020 · 6 comments
Closed

Removing python 2.7 #538

Pomax opened this issue Feb 21, 2020 · 6 comments

Comments

@Pomax
Copy link

Pomax commented Feb 21, 2020

With the death of Python 2.7 on January 1st of this year, tools that used to rely on it are now forced to update for Python 3. For the Node community, the most important tool in that space is node-gyp, which has thankfully already supported Python 3 for quite a few versions, but the version that is used by npm is not quite recent enough and still has python 2.7 support.

A feature request was filed for npm to update to node-gyp 5.1.0 or higher so that any mention of python 2.7 can finally be removed from node-gyp, but some coordination is probably required to make sure that Node.js gets released with a version of npm that relies on a pure Python 3 version of node-gyp.

As such, I figured I file this issue to see what kind of path forward can be taken to make sure the obsolete Python 2.7 is no longer part of the Node ecosystem.

@MylesBorins
Copy link
Contributor

MylesBorins commented Feb 21, 2020 via email

@Pomax
Copy link
Author

Pomax commented Feb 21, 2020

Something that's absolutely worth making sure of - I was going by https://pythonclock.org/ which reports it as already dead, but a press release that pushes the date back to April is certainly more authoritative.

@cclauss
Copy link

cclauss commented Feb 21, 2020

@sam-github
Copy link
Contributor

nodejs/node#25789 (comment) discusses the plan wrt. Python 3 support.

the version that is used by npm is not quite recent enough and still has python 2.7 support.

... and it also has Python 3 support, so should work for everybody. This is a good thing.

@Pomax
Copy link
Author

Pomax commented Feb 21, 2020

It absolutely is, but python 2.7 is now a (currently very low) security risk (but will increase in severity over time), so it's good to make sure that there's a new Node release eventually (preferably sooner than later, of course) that cannot lead to python 2.7 exploits because nothing it comes with even tries to use it.

(Something that will become especially important for users on operating systems that rely on their preinstalled python 2.7, like MacOS. Some of those won't be able to upgrade due to hardware compatibility, some can't even update past Mojave due to software compatibility, etc)

@richardlau
Copy link
Member

The most recent versions of Node.js 10.x, 12.x and 14.x contain npm 6.14.4 which includes node-gyp 5.1.0 which supports Python 3 and 2. I'm going to close this out as there doesn't appear to be any further coordination required from the release team.

Discussions about removing support for legacy Python continues in e.g. nodejs/node-gyp#2052, nodejs/node-gyp#2093.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants