-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: notable-changes
bot comment for summaries
#821
Comments
I think it's a very good idea! |
strong +1 |
+1 from me, sounds like a good idea :) |
RafaelGSS
pushed a commit
to nodejs/node
that referenced
this issue
Apr 5, 2023
PR-URL: #47078 Fixes: nodejs/Release#821 Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
to nodejs/node
that referenced
this issue
Apr 7, 2023
PR-URL: #47078 Fixes: nodejs/Release#821 Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
added a commit
to nodejs/node
that referenced
this issue
Jul 6, 2023
PR-URL: #47078 Fixes: nodejs/Release#821 Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Something I've been thinking about for a while is extending the bot to add a comment whenever the notable changes label is added to a PR in
nodejs/node
. I haven't tried crafting it, but I'm assuming it'd be possible to implement.The comment would say something like:
Why?
Proposing this here first to see if @nodejs/release thinks it's a good idea. We'll likely need to propose it more widely.
The text was updated successfully, but these errors were encountered: