Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version 8 LTS start year #195

Merged
merged 1 commit into from
May 11, 2017
Merged

update version 8 LTS start year #195

merged 1 commit into from
May 11, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 4, 2017

No description provided.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops. lol

@@ -33,7 +33,7 @@
},
"v8": {
"start": "2017-04-30",
"lts": "2016-10-31",
"lts": "2017-10-31",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme currently says 2017-10-01. These should be consistent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schedule.ical also refers to 2017-10-01

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nodejs/lts should this be 10-01 or 10-31? Either way let's fix and land.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should specify the month and no date. update day closer to

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for emitting the day. Feels too specific, especially since LTS does not guarantee the LTS version will be cut on that day.

@cjihrig cjihrig mentioned this pull request Apr 22, 2017
@jasnell
Copy link
Member

jasnell commented Apr 24, 2017

+1 to omitting the day. Just list the month and year

@gibfahn
Copy link
Member

gibfahn commented May 10, 2017

@nodejs/lts any objections to just landing this as is? The question about day of the month is likely to be a moot point once/if #141 lands.

@gibfahn gibfahn merged commit 6a76441 into nodejs:master May 11, 2017
ChALkeR pushed a commit to ChALkeR/LTS that referenced this pull request Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants