-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update version 8 LTS start year #195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops. lol
@@ -33,7 +33,7 @@ | |||
}, | |||
"v8": { | |||
"start": "2017-04-30", | |||
"lts": "2016-10-31", | |||
"lts": "2017-10-31", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme currently says 2017-10-01
. These should be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
schedule.ical
also refers to 2017-10-01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nodejs/lts should this be 10-01
or 10-31
? Either way let's fix and land.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should specify the month and no date. update day closer to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for emitting the day. Feels too specific, especially since LTS does not guarantee the LTS version will be cut on that day.
+1 to omitting the day. Just list the month and year |
@nodejs/lts any objections to just landing this as is? The question about day of the month is likely to be a moot point once/if #141 lands. |
No description provided.