meta: update dates for 4.x EOL and 6.x maintenance #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @nodejs/lts |
gibfahn
approved these changes
Oct 26, 2017
cjihrig
approved these changes
Oct 26, 2017
richardlau
approved these changes
Oct 26, 2017
|
I'm throwing this on the agenda so was can assure we have signoff on the new dates |
I've updated the schedule.json and the README.md Closes: nodejs#264
MylesBorins
force-pushed
the
2018-lts-dates
branch
from
a34ff9d
to
b7603c0
Compare
|
updated based on conversation in #264 PTAL |
This was referenced Nov 17, 2017
gibfahn
approved these changes
Nov 19, 2017
README.md
Outdated
| @@ -6,9 +6,9 @@ | |||
| | :--: | :---: | :---: | :---: | :---: | :---: | | |||
| | v0.10.x | **End-of-Life** | - | - | 2015-10-01 | 2016-10-31 | | |||
| | v0.12.x | **End-of-Life** | - | - | 2016-04-01 | 2016-12-31 | | |||
| | [4.x][] | **Maintenance LTS** | [Argon][] | 2015-10-01 | 2017-04-01 | April 2018 | | |||
| | [4.x][] | **Maintenance LTS** | [Argon][] | 2015-10-01 | 2017-04-01 | 2017-04-31 | | |||
|
I could have sworn I got that right. I checked my knuckles and everything
…On Nov 18, 2017 7:51 PM, "Gibson Fahnestock" ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM except for nit
------------------------------
In README.md
<#265 (comment)>:
> @@ -6,9 +6,9 @@
| :--: | :---: | :---: | :---: | :---: | :---: |
| v0.10.x | **End-of-Life** | - | - | 2015-10-01 | 2016-10-31 |
| v0.12.x | **End-of-Life** | - | - | 2016-04-01 | 2016-12-31 |
-| [4.x][] | **Maintenance LTS** | [Argon][] | 2015-10-01 | 2017-04-01 | April 2018 |
+| [4.x][] | **Maintenance LTS** | [Argon][] | 2015-10-01 | 2017-04-01 | 2017-04-31 |
Don't think April 31 exists 😉
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#265 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAecV5VLHqBqHF4fUaJQbWtCYRpImCRMks5s33upgaJpZM4QH5f8>
.
|
Fishrock123
approved these changes
Nov 20, 2017
|
！ |
This was referenced Dec 7, 2017
mhdawson
approved these changes
Jan 5, 2018
ChALkeR
pushed a commit
to ChALkeR/LTS
that referenced
this pull request
Jun 30, 2018
I've updated the schedule.json and the README.md Closes: nodejs#264
|
Donde está Libramarkets? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the schedule.json and the README.md
Not sure the best way to update schedule.ical, how do we create it?
There is a part of me that thinks we should remove it and put the dates
on the official calendar. I'll open another PR for that
Closes: #264