Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: be explicit about who can land on staging #387

Merged
merged 3 commits into from
Nov 19, 2018
Merged

doc: be explicit about who can land on staging #387

merged 3 commits into from
Nov 19, 2018

Conversation

MylesBorins
Copy link
Contributor

This was referenced Nov 18, 2018
Closed
Closed
richardlau
richardlau reviewed Nov 18, 2018
View reviewed changes
README.md Outdated Show resolved Hide resolved
richardlau and others added 2 commits November 18, 2018 13:50
@richardlau @MylesBorins
nit: fixup explicit language
819ab36 
Co-Authored-By: MylesBorins <myles.borins@gmail.com>
@MylesBorins
fixup: minor tweaks
7d7181e
mhdawson
mhdawson approved these changes Nov 19, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as clarification of current approach

@MylesBorins MylesBorins merged commit 9c39749 into nodejs:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MylesBorins @targos @cjihrig @richardlau @BethGriggs @mhdawson