schedule: give v12.x LTS its codename #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is https://nodejs.org/download/release/latest-erbium/ going to be automatically created or something needs to be manually done? |
richardlau
approved these changes
Oct 15, 2019
| @@ -156,6 +156,7 @@ only landed in the `v4.x` branch when a new `v4.x` release is being prepared.** | |||
| [Boron]: https://nodejs.org/download/release/latest-boron/ | |||
| [Carbon]: https://nodejs.org/download/release/latest-carbon/ | |||
| [Dubnium]: https://nodejs.org/download/release/latest-dubnium/ | |||
| [Erbium]: https://nodejs.org/download/release/latest-erbium/ | |||
There was a problem hiding this comment.
We'll need to remember to add erbium to https://github.com/nodejs/nodejs-latest-linker/blob/46a6c7069a2c30028d149985327a34a71e69878e/latest-linker.js#L10-L15 for this link to get created. I'm unsure of the sequencing (whether it should happen before or after the release).
There was a problem hiding this comment.
Thanks, I opened the PR: nodejs/nodejs-latest-linker#3
BethGriggs
approved these changes
Oct 15, 2019
cjihrig
approved these changes
Oct 15, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because I think it shouldn't land before 12.13.0 is released.