Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominating RafaelGSS to the TSC #1308

Closed
BethGriggs opened this issue Nov 16, 2022 · 28 comments · Fixed by #1314
Closed

Nominating RafaelGSS to the TSC #1308

BethGriggs opened this issue Nov 16, 2022 · 28 comments · Fixed by #1314

Comments

@BethGriggs
Copy link
Member

I would like to nominate @RafaelGSS to the TSC. In addition to code contributions to Node.js core, Rafael has a record of collaboration across multiple teams and working groups including: Release WG (co-led the recent major release, security releases, and regular releases), Security WG, security release stewarding and triage, and many other groups and teams. He has also led discussions in the project such as security best practices, threat model, and experimental features.

I think Rafael would be a great addition to the TSC and would offer valuable additional context from the many teams he is involved in.

There have been no objections from the private TSC discussion, and I have verified his interest.

@richardlau
Copy link
Member

+1 from me.

@jasnell
Copy link
Member

jasnell commented Nov 16, 2022

+1

2 similar comments
@aduh95
Copy link
Contributor

aduh95 commented Nov 17, 2022

+1

@cjihrig
Copy link
Contributor

cjihrig commented Nov 17, 2022

+1

@gireeshpunathil
Copy link
Member

+1. (Also worth mentioning the contributions and initiatives in the Diagnostics WG.)

@ShogunPanda
Copy link
Contributor

Big +1! Totally deserved!

@PaulaPaul
Copy link

I'm always so impressed by how hard @RafaelGSS works and how passionate he is about this work - I'm sure he will be a valuable member of the TSC! +1!

@mhdawson
Copy link
Member

+1 from me

@Trott
Copy link
Member

Trott commented Nov 17, 2022

+1

@RaisinTen
Copy link
Contributor

Definitely +1!

@joyeecheung
Copy link
Member

+1

1 similar comment
@apapirovski
Copy link
Member

+1

@aduh95
Copy link
Contributor

aduh95 commented Nov 23, 2022

@nodejs/tsc Please comment +1 if you are in favor, -1 if you are against, or if you want to abstain please also say so. Several members have reacted with a 👍 which seems to indicate they are in favor but haven't commented, so please consider doing so :) (@BethGriggs don't forget that you being the one open the issue doesn't mean you can't vote on it, I would need an explicit +1 from you as well).
I suggest to keep it open for another 7 days to give time for everyone to vote, but if we get all the votes before that, that's for the better.

Keeping track of votes in this comment.

Yes: 16 (@aduh95, @apapirovski, @BethGriggs, @BridgeAR, @cjihrig, @fhinkel, @GeoffreyBooth, @gireeshpunathil, @jasnell, @joyeecheung, @legendecas, @mhdawson, @RaisinTen, @richardlau, @targos, @Trott)
No: 0
Abstain: 0
To-be-determined: 5 ( @ChALkeR @danielleadams @mcollina, @ronag @tniessen)

@targos
Copy link
Member

targos commented Nov 23, 2022

+1. I assumed 👍 would count as a vote

@richardlau
Copy link
Member

+1 as vote.

@legendecas
Copy link
Member

+1

@BethGriggs
Copy link
Member Author

BethGriggs commented Nov 23, 2022

+1. I assumed we'd count both 👍🏻 from TSC members and the original nomination as a vote as we have in the past (#1282 (comment)).

@GeoffreyBooth
Copy link
Member

+1

@Trott
Copy link
Member

Trott commented Nov 23, 2022

In the past, GitHub reactions were understood to count as votes. I can see a reason for changing that in that after enough reactions, it becomes hard to see everyone who reacted. (You can still get the full list from the API but that's not convenient.)

I do think, though, that it is abundantly safe to assume that the person who is nominating is voting "yes" and that is what we have always done in the past.

@aduh95
Copy link
Contributor

aduh95 commented Nov 23, 2022

I can't find it again, but I remember that at some point someone pointed out that reactions are not a great tool for this kind of vote as it doesn't send notifications and it doesn't leave a trace if someone is changing their vote. (or maybe in the API, but comments are just way easier to check.)

I do think, though, that it is abundantly safe to assume that the person who is nominating is voting "yes" and that is what we have always done in the past.

Yeah actually, that makes sense, for this kind of issue there's no reason for someone to open a nomination they don't support without saying in the OP they don't support it.

@BridgeAR
Copy link
Member

+1

@mhdawson
Copy link
Member

@aduh95 how about we give people 6 days from the time of your comment, I think that might let us close the vote before the next meeting on the 30th. Rafael will be invited for the OSSF discussion anyway but it would be nice to have him confirmed by then.

@mhdawson
Copy link
Member

mhdawson commented Nov 29, 2022

I'll have to check to see if any additional TSC member voted from what is tallied in #1308 (comment) but there are no new objections so I think we can considered this complete.

I volunteered to onboard @RafaelGSS since @BethGriggs is out this week. I'm going to start that tomorrow.

@fhinkel
Copy link
Member

fhinkel commented Nov 30, 2022

+1

@mhdawson
Copy link
Member

mhdawson commented Nov 30, 2022

Starting onboarding

mhdawson added a commit to mhdawson/email that referenced this issue Nov 30, 2022
Refs: nodejs/TSC#1308

Signed-off-by: Michael Dawson <mdawson@devrus.com>
mhdawson added a commit to mhdawson/io.js that referenced this issue Nov 30, 2022
Refs: nodejs/TSC#1308

Signed-off-by: Michael Dawson <mdawson@devrus.com>
mhdawson added a commit to nodejs/create-node-meeting-artifacts that referenced this issue Nov 30, 2022
Refs: nodejs/TSC#1308

Signed-off-by: Michael Dawson <mdawson@devrus.com>
mhdawson added a commit to nodejs/email that referenced this issue Nov 30, 2022
Refs: nodejs/TSC#1308

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson
Copy link
Member

@mcollina and @ronag were +1 in the thumbs up in original post, @danielleadams was in the hurray as well and therefore believe was in the thumbs (which we can't tell) counting them as part of final votes. Let me know if that was not the right thing to do.

Based on that I have the final vote as :

Yes: 18 (@aduh95, @apapirovski, @BethGriggs, @BridgeAR, @cjihrig, @danielleadams, @fhinkel, @GeoffreyBooth, @gireeshpunathil, @jasnell, @joyeecheung, @legendecas, @mcollina, @mhdawson, @RaisinTen, @richardlau, @ronag, @targos, @Trott)
No: 0
Abstain: 0

@aduh95
Copy link
Contributor

aduh95 commented Nov 30, 2022

@mhdawson I'm going to open a PR to register the vote counting the 👍 and the 🎉 as you're suggesting, and let's see if someone wants to object to it for the sake of following the processes. In any case, it doesn't change the issue of the vote.

aduh95 added a commit that referenced this issue Nov 30, 2022
nodejs-github-bot pushed a commit to nodejs/node that referenced this issue Nov 30, 2022
Refs: nodejs/TSC#1308

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #45691
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
mhdawson added a commit to nodejs/create-node-meeting-artifacts that referenced this issue Nov 30, 2022
Refs: nodejs/TSC#1308

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson
Copy link
Member

@aduh95 thanks, that was next on my list of PRs. With that done I'm going to close out this issue.

Trott pushed a commit that referenced this issue Nov 30, 2022
* add vote data for RafaelGSS nomination

Fixes: #1308

* fix grammar
targos pushed a commit to nodejs/node that referenced this issue Dec 12, 2022
Refs: nodejs/TSC#1308

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #45691
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to nodejs/node that referenced this issue Dec 30, 2022
Refs: nodejs/TSC#1308

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #45691
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to nodejs/node that referenced this issue Dec 30, 2022
Refs: nodejs/TSC#1308

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #45691
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to nodejs/node that referenced this issue Jan 3, 2023
Refs: nodejs/TSC#1308

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #45691
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to nodejs/node that referenced this issue Jan 4, 2023
Refs: nodejs/TSC#1308

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #45691
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to nodejs/node that referenced this issue Jan 5, 2023
Refs: nodejs/TSC#1308

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #45691
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Johnhvy added a commit to Johnhvy/NodeJS-Email that referenced this issue Jul 16, 2024
Refs: nodejs/TSC#1308

Signed-off-by: Michael Dawson <mdawson@devrus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.