Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordination on npm releases #528

Closed
mcollina opened this issue Apr 21, 2018 · 7 comments
Closed

Coordination on npm releases #528

mcollina opened this issue Apr 21, 2018 · 7 comments

Comments

@mcollina
Copy link
Member

As nodejs/node#20190 comes in I was totally surprised that we did not discuss at all which version of npm we were going to ship in Node 10. We can do better.

I think we should do either a quarterly update, or just a sync 2-3 months before any major release.
I'm happy to take this responsibility if there are no other volunteers in the @nodejs/tsc or @nodejs/release. (I have never updated npm on node, so there are plently of people way more qualified than me on the coding side, and if you want to take this, please do).

I'm tagging this tsc-agenda, but I'll skip next meeting (I'm on vacation).

cc @iarna @zkat

@jasnell
Copy link
Member

jasnell commented Apr 21, 2018

As with everything, it requires an owner. We only have so much visibility and coordnation into what v8 release we're going to ship because of the diligent work by @targos, @fhinkel and the whole @nodejs/v8 team to actively integrate, test, and discuss on an ongoing basis. I the prep for 10.0.0 I never needed to coordinate what v8 was going to land because of the diligence of that team in keeping things updated and communicated.

The same kind of ongoing effort can be applied here. Dropping a major pre-stable update PR late in the day on a Friday with only one full business day before the actual release makes things extremely difficult. I know there was some confusion on the npm side about the release date, but even if we were releasing on the 30th like they originally thought, this pr is coming very late in the process. What would be far more helpful is earlier proactive communication in both directions and a more incremental process. If nothing else, it would have been helpful if an npm6 tracking issue had been opened a month or two ago and attached to the 10.0.0 milestone.

My apologies if I'm coming off a bit grumpy but I just spent a week testing 10.0.0 test builds and was looking forward to some downtime over the weekend and now with this pr I find myself having to give up weekend family time to do more testing in order to get this update landed in time.

@mhdawson
Copy link
Member

I agree being more proactive as @mcollina suggests. Sounds like @mcollina if volunteering to the "champion" and we could add npm to the list of strategic initiatives as we did for v8 as a regular reminder for updates/making sure we are on track.

@fhinkel
Copy link
Member

fhinkel commented Apr 23, 2018

@mcollina does this need to be tagged with tsc-agenda? Seems to me like there's consensus within @nodejs/release.

@mcollina
Copy link
Member Author

tsc-agenda can be removed.

@MylesBorins
Copy link
Contributor

MylesBorins commented Apr 26, 2018 via email

@mhdawson
Copy link
Member

mhdawson commented May 9, 2018

@mcollina ssuming @MylesBorins PR to add himself as the champion for this can the issue be closed?

@mcollina
Copy link
Member Author

mcollina commented May 9, 2018

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants