-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add minutes for 2017 Apr 6 #238
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhdawson
force-pushed
the
minutes6apr
branch
2 times, most recently
from
April 6, 2017 21:42
b2981ed
to
a904266
Compare
nebrius
reviewed
Apr 6, 2017
meetings/2017-04-06.md
Outdated
|
||
### Nominating Michael Dawson to the TSC [206](https://github.com/nodejs/TSC/issues/206) | ||
|
||
* 9/12 voted +1in github so passed, welcome Michael! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: space between the +1
and in
, and remove a space between github
and so
This was referenced Apr 6, 2017
@nebrius pushed commit to address comments |
nebrius
approved these changes
Apr 10, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mhdawson
added a commit
that referenced
this pull request
Apr 11, 2017
PR-URL: #238 Reviewed-By: Brian Hughes <bryan@theoreticalideations.com>
mhdawson
added a commit
that referenced
this pull request
Apr 11, 2017
PR-URL: #238 Reviewed-By: Brian Hughes <bryan@theoreticalideations.com>
Landed as eb6b509 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.