-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: adopt the contributor covenant CoC #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for putting this together!
Moderation-Policy.md
Outdated
* Respect that people have differences of opinion and that every design or implementation choice carries a trade-off and numerous costs. There is seldom a right answer. | ||
* Please keep unstructured critique to a minimum. If you have solid ideas you want to experiment with, make a fork and see how it works. | ||
* Insulting, demeaning, or harassing anyone, in public or in private, is not welcome behavior and will be grounds for banning from the project. | ||
* Use of personal pronouns in code comments and documentation is to be avoided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the CoC never really was a good place for this statement, and the moderation policy seems even less so… can we move this to doc/STYLE_GUIDE.md in nodejs/node or so?
## Enforcement | ||
|
||
Instances of abusive, harassing, or otherwise unacceptable behavior may be | ||
reported by contacting the project team at report@nodejs.org. All |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the commentary in the issue that it’s not a good thing that readers can’t tell who is reachable at this email address (I don’t even know for sure), and that the possibility of reaching out to trusted individuals isn’t mentioned here (which is, at this point, the course of action that I would personally recommend to anyone who wants to report a problem).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we instead used tsc@iojs.org or commcomm@iojs.org (the latter would need to be created)? This would at least indicate which group of people the email would go to, and maybe add a blurb such as or contact a member of the [TSC](https://github.com/nodejs/TSC#tsc-members) or [CommComm](https://github.com/nodejs/community-committee#community-committee-members) directly
?
Instances of abusive, harassing, or otherwise unacceptable behavior may be | ||
reported by contacting the project team at report@nodejs.org. All | ||
complaints will be reviewed and investigated and will result in a response that | ||
is deemed necessary and appropriate to the circumstances. The project team is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everywhere else "project maintainers" is used, except here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text is taken entirely from the Contributor Covenant word for word. Changes would need to be proposed there.
I think this is just about ready to merge. The one remaining issue is the email notification. Our current moderation policy points to report@nodejs.org so that's what I think we should go with for now. If we want to change that policy, then ok, but let's get this merged and then look at that. |
Ping @nodejs/tsc ... one final call for objections. If there are no objections by Friday I will land. |
ping @jasnell I don’t know, do you want to address the comments here? If you want to merge this as-is, it should be fine. |
Let me take another look this afternoon. |
@nodejs/tsc ... final call. I'll land either later today or tomorrow if there are no objections. |
@nodejs/collaborators @nodejs/tsc @nodejs/ctc ... given how long this has been open, the signoff and the lack of any objections, I'm calling it approved. Will land this now! |
Fixes: #261
@nodejs/tsc
/cc @nodejs/collaborators