Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add inclusivity working group #29

Merged
merged 1 commit into from
Jan 14, 2016

Conversation

ashleygwilliams
Copy link
Contributor

@jasnell
Copy link
Member

jasnell commented Jan 11, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Jan 11, 2016

@nodejs/tsc

@mikeal
Copy link
Contributor

mikeal commented Jan 12, 2016

Looks great :)

@rvagg
Copy link
Member

rvagg commented Jan 13, 2016

A couple of different bullet-point styles in use there (- and +, indented and non-indented first line, aligned and non-aligned subsequent lines), would you mind picking one pls @ashleygwilliams cause this will set the format for future additions to the doc.

I see we have an unfortunate mix of >2 styles in the core repo WORKING_GROUPS.md, perhaps we can pick a style here and update there afterwards.

@ashleygwilliams
Copy link
Contributor Author

totally @rvagg! good feedback. i was actually copying what i saw in the core WORKING_GROUPS hahaha, hence the multiple styles!

any preference? (i have none except preferring consistency, which it seems we share 😄)

@jasnell
Copy link
Member

jasnell commented Jan 13, 2016

Lol yeah, we gotta fix the styles in that one too
On Jan 12, 2016 4:56 PM, "ashley williams" notifications@github.com wrote:

totally @rvagg https://github.com/rvagg! good feedback. i was actually
copying what i saw in the core WORKING_GROUPS hahaha, hence the multiple
styles!

any preference? (i have none except preferring consistency, which it seems
we share [image: 😄])


Reply to this email directly or view it on GitHub
#29 (comment).

@rvagg
Copy link
Member

rvagg commented Jan 13, 2016

Looking over other top-level .md files I think I'm seeing this format showing up the most, although there is a bit of variation:

* Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor
  incididunt ut labore et dolore magna aliqua.
* Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip
  ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit
  esse cillum dolore eu fugiat nulla pariatur.
* Excepteur sint occaecat cupidatat non proident.

This is the style I personally use but in this case I only care about consistency.

@nodejs/documentation suggestions for a style to adopt? Perhaps we have a prevailing style in the docs?

@ashleygwilliams
Copy link
Contributor Author

wfm. i'll update + amend.

@ashleygwilliams
Copy link
Contributor Author

oh whoops, missed your ask of @nodejs/documentation. will hold off til tomorrow.

@rvagg
Copy link
Member

rvagg commented Jan 13, 2016

@ashleygwilliams my vote for now would be to just adopt a consistent style and we'll do a general cleanup later across files. I'd love if @nodejs/documentation could head that but I'm not sure they are organised enough yet.

@ashleygwilliams
Copy link
Contributor Author

fair enough! incoming.

@ashleygwilliams
Copy link
Contributor Author

updated this @rvagg ICYMI. if yer just busy or working on something else, no worries!

@jasnell
Copy link
Member

jasnell commented Jan 13, 2016

Still LGTM :-) ... one minor nit tho @ashleygwilliams ... the #### Process: header depth ends up causing it to be nested under the Inclusivity WG charter. Can you either move it up a level by dropping one of the #'s or move the #### Process section up above the Inclusivity Charter itself?

@ashleygwilliams
Copy link
Contributor Author

ah, excellent catch @jasnell -- do you have a preference re: solution? i think removing the # is best, personally, but i don't have strong feelings.

@jasnell
Copy link
Member

jasnell commented Jan 13, 2016

I'm good with either. Begone with the #! ;)
On Jan 13, 2016 1:33 PM, "ashley williams" notifications@github.com wrote:

ah, excellent catch @jasnell https://github.com/jasnell -- do you have
a preference re: solution? i think removing the # is best, personally,
but i don't have strong feelings.


Reply to this email directly or view it on GitHub
#29 (comment).

@ashleygwilliams
Copy link
Contributor Author

incoming.

@jasnell
Copy link
Member

jasnell commented Jan 13, 2016

Excellent. Thanks much. I'll wait for @rvagg to weigh in before landing... but will go ahead and land tomorrow if there are no objections posted.

@ashleygwilliams
Copy link
Contributor Author

heh, actually, i moved it up and made it a ##, looks like this now, which i think is much clearer than before. thoughts, everyone? cc/@jasnell
screen shot 2016-01-13 at 4 38 35 pm

@jasnell
Copy link
Member

jasnell commented Jan 13, 2016

That works too!

@rvagg
Copy link
Member

rvagg commented Jan 14, 2016

added tsc-agenda label, I'm not sure if it's been through a meeting yet (I missed at least the last one), should be cleared up by tomorrow if we can get a quorum

@ashleygwilliams
Copy link
Contributor Author

thanks for the update @rvagg !

@jasnell
Copy link
Member

jasnell commented Jan 14, 2016

This was just discussed on the TSC call. There were no objections! We should be good to go. I'll get this landed shortly.

mikeal added a commit that referenced this pull request Jan 14, 2016
@mikeal mikeal merged commit fe5d7cd into nodejs:master Jan 14, 2016
@mikeal
Copy link
Contributor

mikeal commented Jan 14, 2016

Ratified in the TSC meeting on Jan 14th.

@ashleygwilliams ashleygwilliams deleted the add-inclusivity branch January 14, 2016 20:35
@ghost
Copy link

ghost commented Jan 14, 2016

WOOT

@nebrius
Copy link
Contributor

nebrius commented Jan 14, 2016

🎉

@zkat
Copy link

zkat commented Jan 14, 2016

🎉👏!!

(post edited 2015-01-15 @ 8:10pm pacific by jasnell to remove a troublesome emoji ... per #29 (comment))

@jasnell
Copy link
Member

jasnell commented Jan 14, 2016

@zkat .. hmm.. just a side note: given the issues we've had with having to moderate users who post comments with eggplants, it's likely not the best choice to include one in #29 (comment). I know your intent is not to troll, but it would be rather hypocritical of us to not apply the same moderation criteria to your post as we do others :-)

@Trott Trott removed the tsc-agenda label Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get ratified by the TSC
7 participants