-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add minutes for meeting Oct 31 #619
Conversation
* fs: behaviour of readFile and writeFile with file descriptors [#23433](https://github.com/nodejs/node/issues/23433) | ||
* Vote has been suggested. | ||
* Michael have we had complaints from end users | ||
* Sakthipriyan - believe just raised by collaborators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorangreef is not a collaborator, and originally raised nodejs/node#9671
@thisconnect and @bzoz from nodejs/node#13572 are not collaborators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bzoz is a collaborator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sam-github Ah, thanks for correcting my understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
behavior of readFile and writeFile with file descriptors
Thank you all for looking into this and taking action! It doesn't matter which direction you choose, everything is better than current situation. There only mistake would be to do nothing. :)
Co-Authored-By: mhdawson <michael_dawson@ca.ibm.com>
* fs: behaviour of readFile and writeFile with file descriptors [#23433](https://github.com/nodejs/node/issues/23433) | ||
* Vote has been suggested. | ||
* Michael have we had complaints from end users | ||
* Sakthipriyan - believe just raised by collaborators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sam-github Ah, thanks for correcting my understanding.
meetings/2018-10-31.md
Outdated
* Michael have we had complaints from end users | ||
* Sakthipriyan - believe just raised by collaborators | ||
* Matteo has this been assessed by Canary in the Goldmine | ||
* Not yet seomething we should do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, CITGM was tried for the first option's PR (nodejs/node#23709), but the failing tests were already failing for sometime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thefourtheye updated to reflect that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.