Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add minutes for meeting 10 April 2019 #690

Merged
merged 1 commit into from
Apr 18, 2019
Merged

doc: add minutes for meeting 10 April 2019 #690

merged 1 commit into from
Apr 18, 2019

Conversation

mhdawson
Copy link
Member

No description provided.

@mhdawson mhdawson mentioned this pull request Apr 10, 2019
Closed
@mhdawson
Copy link
Member Author

@nodejs/TSC would be good to get a review on this so it can be landed.

@Trott
Copy link
Member

Trott commented Apr 17, 2019

@nodejs/TSC would be good to get a review on this so it can be landed.

Careful. When you capitalize TSC like that, it doesn't notify anyone:

@nodejs/TSC vs @nodejs/tsc

Trott
Trott approved these changes Apr 17, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't there but rubber-stamp LGTM anyway.

@richardlau
Copy link
Member

Commit title has mispelled April.

@mhdawson mhdawson changed the title doc: add minutes for meeting 10 Apri 2019 doc: add minutes for meeting 10 April 2019 Apr 18, 2019
@mhdawson mhdawson merged commit a3fbd83 into nodejs:master Apr 18, 2019
@mhdawson mhdawson deleted the meeting10APr branch August 14, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhdawson @Trott @richardlau