Document lifetime of napi_get_last_error_info #251
Comments
mhdawson
added a commit
to mhdawson/io.js
that referenced
this issue
Jun 26, 2017
Document the lifetime of the structure returned by napi_get_last_error_info Fixes: nodejs/abi-stable-node#251
3 tasks
addaleax
pushed a commit
to nodejs/node
that referenced
this issue
Jun 29, 2017
Document the lifetime of the structure returned by napi_get_last_error_info PR-URL: #13939 Fixes: nodejs/abi-stable-node#251 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
addaleax
pushed a commit
to nodejs/node
that referenced
this issue
Jul 11, 2017
Document the lifetime of the structure returned by napi_get_last_error_info PR-URL: #13939 Fixes: nodejs/abi-stable-node#251 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
addaleax
pushed a commit
to nodejs/node
that referenced
this issue
Jul 18, 2017
Document the lifetime of the structure returned by napi_get_last_error_info PR-URL: #13939 Fixes: nodejs/abi-stable-node#251 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this issue
Apr 10, 2018
Document the lifetime of the structure returned by napi_get_last_error_info PR-URL: nodejs#13939 Fixes: nodejs/abi-stable-node#251 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
MylesBorins
pushed a commit
to nodejs/node
that referenced
this issue
Apr 16, 2018
Document the lifetime of the structure returned by napi_get_last_error_info Backport-PR-URL: #19447 PR-URL: #13939 Fixes: nodejs/abi-stable-node#251 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Unlike napi_get_cb_info, napi_get_last_error_info doesn’t accept a pointer from callee, but instead is expected to return its own.
For such case it's useful both for implementors and consumers to know the minimal runtime they should keep pointer to the structure and included message around and be able to use it.
As we discussed in the meeting, it likely will be "until the next N-API call".
The text was updated successfully, but these errors were encountered: